Updated fasterxml jackson dependency #92
Conversation
WalkthroughThe Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
pom.xml (1)
158-161: 🛠️ Refactor suggestionVersion mismatch: jackson-datatype-joda remains at 2.17.0
Your
jackson-datatype-jodadependency is still on 2.17.0, which is incompatible with the 2.19.0 core modules. Please update it to 2.19.0 or remove the version so Spring Boot’s BOM can manage it.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pom.xml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-core</artifactId> | ||
| <version>2.17.0-rc1</version> | ||
| <version>2.19.0</version> | ||
| </dependency> |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Mixed Jackson versions: Consider alignment or BOM management
While you’ve upgraded jackson-core to 2.19.0, other modules (annotations, databind, datatype-joda) must all share the same version to avoid classpath conflicts. If you intend to pin versions manually, ensure every Jackson artifact is at 2.19.0. A cleaner approach is to remove explicit Jackson versions here and let Spring Boot’s dependency management (parent POM) enforce a consistent, tested Jackson version set.
🤖 Prompt for AI Agents
In pom.xml around lines 140 to 143, the jackson-core version is set to 2.19.0
while other Jackson modules have different versions, causing potential
conflicts. To fix this, either update all Jackson dependencies (annotations,
databind, datatype-joda) to version 2.19.0 for consistency or remove the
explicit version tags from all Jackson dependencies and rely on Spring Boot's
parent POM to manage and align the Jackson versions automatically.
|
2 participants
📋 Description
JIRA ID: AMM-1452
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit